Refactor Tests#413
Draft
danielchrist0pher wants to merge 4 commits intomainfrom
Draft
Conversation
Member
Author
|
Got a base going - now going to refactor tests to use direct replication rather than hyperswarm. |
Member
Author
|
Tests are refactored to use direct replication where possible. We do have one E2E test using hyperswarm - not sure this warrants its own dedicated "e2e" file. But nice to have, in case we want to grow the suite. |
lejeunerenard
requested changes
Apr 14, 2026
| return b4a.concat(chunks) | ||
| } | ||
|
|
||
| async function replicate(drive, swarm, mirror) { |
Contributor
There was a problem hiding this comment.
This should be renamed something to do with swarming, maybe event just swarm().
| while (drive.db.core.length < length) await once(drive.db.core, 'append') | ||
| } | ||
|
|
||
| function pipeReplicate(drive, mirror) { |
Contributor
There was a problem hiding this comment.
Rename to replicate() like other helpers eg https://github.com/holepunchto/hypercore/blob/6daacb9bcd1d6fb1ba203ade60db75a3d6027dae/test/helpers/index.js#L35
Contributor
There was a problem hiding this comment.
All of these tests are unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.